Skip to content

Fix nullable_kvs fallback #16837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 18, 2025
Merged

Fix nullable_kvs fallback #16837

merged 4 commits into from
Apr 18, 2025

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Apr 18, 2025 •
edited by github-actions bot
Loading

Fix errors from #16789:

  • --limit-mm-per-prompt now falls back to nullable_kvs correctly
  • json.dumps is used instead of str to generate JSON strings for entrypoints tests

hmellor added 3 commits April 18, 2025 12:21
@hmellor
Fix test where limit_mm_per_prompt cannot be None
98c5f6e 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Use dict for limit_per_prompt so it's detected in conversion to a…
a61d788 
…rgparse

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Fallback to nullable_kvs without error
2b96a3c 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Apr 18, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 18, 2025
@hmellor hmellor changed the title Fix-nullable-kv-fallback Fix nullable_kvs fallback Apr 18, 2025
@hmellor hmellor mentioned this pull request Apr 18, 2025
Merged
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 18, 2025 12:17
@DarkLight1337
Copy link
Member

DarkLight1337 commented Apr 18, 2025

PTAL at the failing entrypoints tests. I think it's related to #16789 as well

@hmellor
Replace str() with json.dumps()
69ceca4 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Copy link
Member Author

hmellor commented Apr 18, 2025

I've tested one model from each of the modalities that were failing and they work fine after the latest commit

@vllm-bot vllm-bot merged commit 686623c into vllm-project:main Apr 18, 2025
10 of 14 checks passed
@hmellor hmellor deleted the fix-nullable-kv-fallback branch April 18, 2025 12:58
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@hmellor @yangw-dev
Fix nullable_kvs fallback (vllm-project#16837)
e201b18 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@hmellor @dbyoung18
Fix nullable_kvs fallback (vllm-project#16837)
212890d 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@hmellor @lk-chen
Fix nullable_kvs fallback (vllm-project#16837)
fdaab2e 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@hmellor @adobrzyn
Fix nullable_kvs fallback (vllm-project#16837)
eb5c855 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Fix nullable_kvs fallback (vllm-project#16837)
d9144bb 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo is a code owner

+1 more reviewer

@markmc markmc markmc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hmellor @DarkLight1337 @markmc @vllm-bot